> On Nov 7, 2016, at 10:27 AM, Hans Petter Selasky <h...@selasky.org> wrote: > > On 11/07/16 18:38, Oleksandr Tymoshenko wrote: >> + bcm2835_audio_unlock(sc); >> + cv_signal(&sc->worker_cv); > > > Shouldn't cv_signal() be done locked, so that you don't loose any > transactions? CV's only wakeup the treads that are sleeping right there and > then.
Hi Hans, In this case it doesn’t matter. bcm2835_audio_xxx lock functions are used to keep channel state consistent. The actual audio hw reprogramming happens in worker thread which only picks up latest state of the virtual channel, there is no need to run every transaction in sequence. _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
