On Tue, Oct 18, 2016 at 03:11:55PM -0700, Ngie Cooper wrote: > (Picking a "random commit") > > On Tue, Oct 18, 2016 at 3:13 AM, Ruslan Bukin <b...@freebsd.org> wrote: > > Author: br > > Date: Tue Oct 18 10:13:54 2016 > > New Revision: 307553 > > URL: https://svnweb.freebsd.org/changeset/base/307553 > > > > Log: > > Skip test on MIPS as it modifies TLS pointer in set_mcontext(). > > > > Discussed with: kib > > Sponsored by: DARPA, AFRL > > Sponsored by: HEIF5 > > > > Modified: > > head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c > > > > Modified: head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c > > ============================================================================== > > --- head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c Tue Oct 18 > > 10:12:55 2016 (r307552) > > +++ head/contrib/netbsd-tests/lib/libpthread/t_swapcontext.c Tue Oct 18 > > 10:13:54 2016 (r307553) > > @@ -97,6 +97,15 @@ ATF_TC_BODY(swapcontext1, tc) > > { > > pthread_t thread; > > > > +#ifdef __mips__ > > + /* > > + * MIPS modifies TLS pointer in set_mcontext(), so > > + * swapping contexts obtained from different threads > > + * gives us different pthread_self() return value. > > + */ > > + atf_tc_skip("Platform is not supported."); > > +#endif > > + > > oself = (void *)&val1; > > nself = (void *)&val2; > > Please add appropriate conditionals to the code, i.e. > - "#ifdef __FreeBSD__" / "#endif" around all blocks that are > FreeBSD-specific, or need to be upstreamed to NetBSD. > - "#ifdef __NetBSD__" / "#endif" around all blocks that are > NetBSD-specific (i.e. test specific NetBSD requirements), do not need > to be upstreamed. > This helps mere mortals (like me) keep track of what's our's, > what's their's, and what should be their's, so I can push back > everything that should be in NetBSD to NetBSD. > If it's not resolved by tonight, I'll work through the queue of > items that need to be cleaned up.
Thanks. Is this rule for ./contrib/netbsd-tests only, or ./tests/ as well ? Ruslan _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
