On Mon, Oct 10, 2016 at 9:50 AM, Ruslan Bukin <ruslan.bu...@cl.cam.ac.uk> wrote: > On Mon, Oct 10, 2016 at 08:04:44AM -0700, Conrad Meyer wrote: >> We also observed this test was broken, but I think the right fix is >> much smaller: >> >> --- a/tests/sys/kern/pipe/pipe_fstat_bug_test.c >> +++ b/tests/sys/kern/pipe/pipe_fstat_bug_test.c >> @@ -108,7 +108,6 @@ main(void) >> SYNC_W(0, go2); >> >> SYNC_R(0, go); >> - SYNC_W(0, go2); /* XXX: why is this required? */ >> WRITE(8192); >> SYNC_W(0, go2); >> >> (That line breaks the synchronization mechanism that is the only >> guarantee the test passes.) > > There is some direct mode activated when you send >=8192, > so this line is required
Given that line breaks the parent-child synchronization entirely and your kevent replaces it, why not remove the remaining go/go2 pipe and read/writes? Best, Conrad _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
