Author: truckman
Date: Wed May 25 00:25:38 2016
New Revision: 300636
URL: https://svnweb.freebsd.org/changeset/base/300636
Log:
Delay calling yp_malloc_dnsent() until after some additional sanity
checks to avoid leaking memory on error returns.
Reported by: Coverity
CID: 1007416
MFC after: 1 week
Modified:
head/usr.sbin/ypserv/yp_dnslookup.c
Modified: head/usr.sbin/ypserv/yp_dnslookup.c
==============================================================================
--- head/usr.sbin/ypserv/yp_dnslookup.c Wed May 25 00:16:52 2016
(r300635)
+++ head/usr.sbin/ypserv/yp_dnslookup.c Wed May 25 00:25:38 2016
(r300636)
@@ -489,9 +489,6 @@ yp_async_lookup_addr(struct svc_req *rqs
yp_find_dnsqent(svcudp_get_xid(rqstp->rq_xprt),BY_RPC_XID) != NULL)
return(YP_TRUE);
- if ((q = yp_malloc_dnsent()) == NULL)
- return(YP_YPERR);
-
switch (af) {
case AF_INET:
if (inet_aton(addr, (struct in_addr *)uaddr) != 1)
@@ -516,6 +513,9 @@ yp_async_lookup_addr(struct svc_req *rqs
return(YP_YPERR);
}
+ if ((q = yp_malloc_dnsent()) == NULL)
+ return(YP_YPERR);
+
if (debug)
yp_error("DNS address is: %s", buf);
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
