On 05/11/16 04:43 PM, Ed Maste wrote: > On 11 May 2016 at 16:06, Jung-uk Kim <j...@freebsd.org> wrote: >> Author: jkim >> Date: Wed May 11 20:06:23 2016 >> New Revision: 299480 >> URL: https://svnweb.freebsd.org/changeset/base/299480 >> > [...] >> ( echo '# $$'FreeBSD'$$' ;\ >> echo '# Do not modify. This file is auto-generated from >> ${.IMPSRC:T}.' ;\ >> echo '#ifdef PIC' ;\ >> - perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\ >> + env CC=cc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\ >> echo '#else' ;\ >> - perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\ >> + env CC=cc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\ > > One thing that occurred to me in the older PIC change here: perhaps we > should explicitly strip -fpic / -DPIC from the passed-in ${CFLAGS} for > the #else. It's unlikely, but possible, that a user could regenerate > the assembly files with -fpic set in CFLAGS.
No user serviceable parts inside. ;-) Seriously, there's no need for overengineering this file. Jung-uk Kim
signature.asc
Description: OpenPGP digital signature
