I seem to be wrong. In any event, we don't have any non-device-tree
platforms on PowerPC anymore, so you can just make it be "pci".
-Nathan
On 03/31/16 01:18, Zbigniew Bodek wrote:
Are you sure? I don't see an example of what you are writing about.
Instead I can see several other examples such as:
dev/usb/controller/ehci_fsl.coptionalehci mpc85xx | ehci qoriq_dpaa
dev/iicbus/adm1030.coptionalpowermac windtunnel | adm1030 powermac
etc.
Why would they do that if they could simply type: ehci mpc85xx |
qoriq_dpaa?
Best regards
zbb
2016-03-30 19:22 GMT+02:00 Nathan Whitehorn <nwhiteh...@freebsd.org
<mailto:nwhiteh...@freebsd.org>>:
I think it should be pci aim | fdt, just like the previous line
when the files lived in sys/powerpc. To conf, that evaluates as
pci && (aim || fdt).
-Nathan
On 03/30/16 08:55, Zbigniew Bodek wrote:
Thank you Nathan. Please check out new patch in the attachment.
Best regards
zbb
2016-03-30 16:33 GMT+02:00 Nathan Whitehorn
<nwhiteh...@freebsd.org <mailto:nwhiteh...@freebsd.org>>:
PowerPC (and SPARC) can have real OFW without FDT support.
Adding FDT to LINT is the wrong solution: rather, it should
switch on fdt | aim like the rest of the Open Firmware code.
-Nathan
On 03/30/16 01:54, Zbigniew Bodek wrote:
Hello Ed,
Please check out the attached patch. For powerpc we should
compile-in ofwpci.c regardless of FDT option.
However, it seems that LINT for powerpc does not have FDT.
What do you thing about adding it (as can be seen in the
attached patch)?. This would be done in a separate commit.
Best regards
zbb
2016-03-30 1:53 GMT+02:00 Ed Maste <ema...@freebsd.org
<mailto:ema...@freebsd.org>>:
On 29 March 2016 at 15:19, Zbigniew Bodek
<z...@freebsd.org <mailto:z...@freebsd.org>> wrote:
> Author: zbb
> Date: Tue Mar 29 15:19:56 2016
> New Revision: 297392
> URL: https://svnweb.freebsd.org/changeset/base/297392
>
> Log:
> Reduce OFW PCI code duplication - involves ARM, PPC
and SPARC64
My 'make tinderbox' build is now failing (powerpc LINT)
with:
linking kernel
cpcht.o: In function `cpcht_attach':
cpcht.c:(.text+0x17dc): undefined reference to
`ofw_pci_attach'
cpcht.o:(.data.rel+0x0): undefined reference to
`ofw_pci_driver'
grackle.o: In function `grackle_attach':
grackle.c:(.text+0x2dc): undefined reference to
`ofw_pci_attach'
grackle.o:(.data.rel+0x0): undefined reference to
`ofw_pci_driver'
uninorthpci.o: In function `uninorth_attach':
uninorthpci.c:(.text+0x68c): undefined reference to
`ofw_pci_attach'
uninorthpci.o:(.data.rel+0x0): undefined reference to
`ofw_pci_driver'
*** [kernel] Error code 1
_______________________________________________
svn-src-...@freebsd.org <mailto:svn-src-...@freebsd.org>
mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to
"svn-src-all-unsubscr...@freebsd.org
<mailto:svn-src-all-unsubscr...@freebsd.org>"
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
