On Fri, Jan 22, 2016 at 05:19:34PM +1100, Lawrence Stewart wrote: L> On 01/22/16 09:53, Gleb Smirnoff wrote: L> > Author: glebius L> > Date: Thu Jan 21 22:53:12 2016 L> > New Revision: 294536 L> > URL: https://svnweb.freebsd.org/changeset/base/294536 L> > L> > Log: L> > Refactor TCP_CONGESTION setsockopt handling: L> > - Use M_TEMP instead of stack variable. L> > - Unroll error handling, removing several levels of indentation. L> L> As noted privately elsewhere, this change introduces races with respect L> to CC algorithm module unloading which will need to be fixed. Just L> mentioning it again publicly so others are aware of it.
In the code checked in the check for (CC_ALGO(tp)->ctl_output being not NULL and the actual call are under the same lock. Is that the race you refer to? -- Totus tuus, Glebius. _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
