On Sun, 2015-12-27 at 21:41 +0300, Slawa Olhovchenkov wrote: > On Sun, Dec 27, 2015 at 10:10:37AM -0700, Ian Lepore wrote: > > > On Sun, 2015-12-27 at 15:37 +0000, Dmitry Chagin wrote: > > > Author: dchagin > > > Date: Sun Dec 27 15:37:07 2015 > > > New Revision: 292777 > > > URL: https://svnweb.freebsd.org/changeset/base/292777 > > > > > > Log: > > > Verify that tv_sec value specified in settimeofday() and > > > clock_settime() > > > (CLOCK_REALTIME case) system calls is non negative. > > > This commit hides a kernel panic in atrtc_settime() as the > > > clock_ts_to_ct() > > > does not properly convert negative tv_sec. > > > > > > ps. in my opinion clock_ts_to_ct() should be rewritten to > > > properly > > > handle > > > negative tv_sec values. > > > > > > Differential Revision: https://reviews.freebsd.org/D4714 > > > Reviewed by: kib > > > > > > MFC after: 1 week > > > > IMO, this change is completely unacceptable. If there is a bug in > > atrtc code, then by all means fix it, but preventing anyone from > > setting valid time values on the system because one driver's code > > can't > > handle it is just wrong. > > You talk about kernel panic when internal data structures not > destructed is normal behavior? Realy? >
I have no idea what you mean by that -- I didn't say anything at all about panic. -- Ian _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
