Looking at the patch, we need a define of your _callout_stop_safe
and we need to switch callout_stop()’s define to use the new _callout_stop_safe() R On Nov 13, 2015, at 4:20 PM, Randall Stewart <r...@netflix.com> wrote: > No alexander’s panic’s are because the > LLREF > is done if (callout_stop()) > > But now if it was not running -1 is returned.. > > Try the patch I just sent.. > > R > On Nov 13, 2015, at 4:02 PM, Bryan Drewery <bdrew...@freebsd.org> wrote: > >> On 11/13/2015 1:00 PM, Randall Stewart wrote: >>> Bryan: >>> >>> This looks like a decent thing to do.. >>> >>> Still wondering why changing the callout.h header file would not have caused >>> things to recompile to pick up the new argument.. >>> >>> We can do it this way though it looks fine. >>> >>> You want to commit it or I? >> >> Well your change is totally safe for compiling. It's just not KBI >> backwards compat for older modules. This is not typically a problem but >> I think in this case it is worth doing to avoid random data coming into >> the 'drain' argument if loading an older module. >> >> I'll do a test build and commit it. Perhaps this is what was leading to >> Alexander's panics. >> >> I haven't analyzed the return value issue at all. >> >> >> -- >> Regards, >> Bryan Drewery >> > > -------- > Randall Stewart > r...@netflix.com > 803-317-4952 > > > > > -------- Randall Stewart r...@netflix.com 803-317-4952 _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
