On 11/5/2015 3:28 PM, Ian Lepore wrote: > On Fri, 2015-11-06 at 09:37 +1030, O'Connor, Daniel wrote: >> Presumably the intent was to have an extra line after the \ so diffs >> are reduced for future additions. >> > > Yeah. I wish we did that pretty much universally wherever lists of > things appear (SRCS and OBJS lists in makefiles, a trailing comma on ar > ray and enum init lists in C, etc). >
Me too. It leads to bugs like this though when an empty line does not follow. We've done this pattern at work but I avoid doing so here. > >>> On 6 Nov 2015, at 09:20, Adrian Chadd <adr...@freebsd.org> wrote: >>> >>> Author: adrian >>> Date: Thu Nov 5 22:50:21 2015 >>> New Revision: 290428 >>> URL: https://svnweb.freebsd.org/changeset/base/290428 >>> >>> Log: >>> remove \, it confuses things. >>> >>> Modified: >>> head/share/man/man9/Makefile >>> >>> Modified: head/share/man/man9/Makefile >>> =================================================================== >>> =========== >>> --- head/share/man/man9/Makefile Thu Nov 5 22:44:36 2015 >>> (r290427) >>> +++ head/share/man/man9/Makefile Thu Nov 5 22:50:21 2015 >>> (r290428) >>> @@ -1294,7 +1294,7 @@ MLINKS+=pci.9 pci_alloc_msi.9 \ >>> pci.9 pci_write_config.9 \ >>> pci.9 pcie_adjust_config.9 \ >>> pci.9 pcie_read_config.9 \ >>> - pci.9 pcie_write_config.9 \ >>> + pci.9 pcie_write_config.9 >>> MLINKS+=pci_iov_schema.9 pci_iov_schema_alloc_node.9 \ >>> pci_iov_schema.9 pci_iov_schema_add_bool.9 \ >>> pci_iov_schema.9 pci_iov_schema_add_string.9 \ -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature
