On Wed, Oct 07, 2015 at 01:58:29AM -0700, NGie Cooper wrote: > > > On Oct 7, 2015, at 01:56, Baptiste Daroussin <b...@freebsd.org> wrote: > > > > Author: bapt > > Date: Wed Oct 7 08:56:01 2015 > > New Revision: 288981 > > URL: https://svnweb.freebsd.org/changeset/base/288981 > > > > Log: > > Trim spaces at the end of the buffer before trying to convert it to an oid > > > > This allows to write entries in sysctl.conf with spaces before the '=' like > > kern.ipc.shmmax = 9663676416 > > > > MFC after: 1 week > > Sponsored by: Gandi.net > > Won’t this cause issues if the intent of the original value is to have a > space before the rest of the value, e.g. > > sysctl my.oid=“ i really wanted a leading space”
Note that here I am only trimming spaces _before_ the = and I'm not touching the parsing after the '=' for the exact reason you are raising. Best regards, Bapt
signature.asc
Description: PGP signature
