> On 16 Jul 2015, at 10:46 , Zbigniew Bodek <z...@freebsd.org> wrote:
>
> Author: zbb
> Date: Thu Jul 16 10:46:52 2015
> New Revision: 285627
> URL: https://svnweb.freebsd.org/changeset/base/285627
>
> Log:
> Fix KSTACK_PAGES issue when the default value was changed in KERNCONF
>
> If KSTACK_PAGES was changed to anything alse than the default,
> the value from param.h was taken instead in some places and
> the value from KENRCONF in some others. This resulted in
> inconsistency which caused corruption in SMP envorinment.
>
> Ensure all places where KSTACK_PAGES are used the opt_kstack_pages.h
> is included.
>
> The file opt_kstack_pages.h could not be included in param.h
> because was breaking the toolchain compilation.
>
> Reviewed by: kib
> Obtained from: Semihalf
> Sponsored by: The FreeBSD Foundation
> Differential Revision: https://reviews.freebsd.org/D3094
Broke i386 (and pc98) LINT kernels:
i386 LINT kernel failed, check _.i386.LINT for details
i386 LINT-NOINET6 kernel failed, check _.i386.LINT-NOINET6 for details
i386 LINT-NOINET kernel failed, check _.i386.LINT-NOINET for details
pc98 LINT kernel failed, check _.pc98.LINT for details
i386 LINT-NOIP kernel failed, check _.i386.LINT-NOIP for details
i386 LINT-VIMAGE kernel failed, check _.i386.LINT-VIMAGE for details
--------------------------------------------------------------
>>> stage 3.1: making dependencies
--------------------------------------------------------------
In file included from /scratch/tmp/bz/head.svn/sys/i386/i386/locore.s:57:
./assym.s:20:9: warning: 'KSTACK_PAGES' macro redefined [-Wmacro-redefined]
#define KSTACK_PAGES 0x3
^
./opt_kstack_pages.h:1:9: note: previous definition is here
#define KSTACK_PAGES 3
^
1 warning generated.
--------------------------------------------------------------
>>> stage 3.2: building everything
--------------------------------------------------------------
In file included from /scratch/tmp/bz/head.svn/sys/i386/i386/locore.s:57:
./assym.s:20:9: error: 'KSTACK_PAGES' macro redefined
[-Werror,-Wmacro-redefined]
#define KSTACK_PAGES 0x3
^
./opt_kstack_pages.h:1:9: note: previous definition is here
#define KSTACK_PAGES 3
^
1 error generated.
--- locore.o ---
*** [locore.o] Error code 1
bmake: stopped in /storage/head/obj/i386.i386/scratch/tmp/bz/head.svn/sys/LINT
—
Bjoern A. Zeeb Charles Haddon Spurgeon:
"Friendship is one of the sweetest joys of life. Many might have failed
beneath the bitterness of their trial had they not found a friend."
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
