On Thu, 2015-07-16 at 06:39 +0100, Mark Murray wrote: > > On 15 Jul 2015, at 23:43, Adrian Chadd <adrian.ch...@gmail.com> wrote: > > > >> - Add harvesting of slab allocator events. This needs to be checked for > >> weighing down the allocator code. > > > > Hi, > > > > Is this really doing it upon every one of those events? eg, for each > > mbuf alloc through UMA? > > Only if you turn it on! > > M >
In random_harvestq_init() I see harvest_context.hc_source_mask = RANDOM_HARVEST_EVERYTHING_MASK; and #define RANDOM_HARVEST_EVERYTHING_MASK ((1 << (RANDOM_ENVIRONMENTAL_END + 1)) - 1) So doesn't that include the RANDOM_FAST flag that controls harvesting during every UMA alloc and free call? And that harvesting appears to be anything but fast, at least at a glance... it looks like it passes the entire struct uma_zone to the jenkins hash function... is there really useful entropy in all the data in that struct? -- Ian _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
