On 20 Jun 2015, at 17:09, Allan Jude <allanj...@freebsd.org> wrote: > > On 2015-06-20 11:05, Benjamin Kaduk wrote: ... >> Are the warnings emitted by gcc posted somewhere so that I can convince >> myself dropping WARNS is better than changing the code to work around them? >> >> -Ben > > The warnings come from the ZFS contrib code, so I was under the > impression we didn't want to fix those and diverge form upstream. > > via kib on irc: > > ===> usr.sbin/fstyp (all) > cc1: warnings being treated as errors > In file included from > /scratch/tmp/kib/src/usr.sbin/fstyp/../../sys/cddl/contrib > from /scratch/tmp/kib/src/usr.sbin/fstyp/zfs.c:41: > n/fs/zfs/sys/dmu.h:638: warning: function declaration isn't a prototype > n/fs/zfs/sys/dmu.h:639: warning: function declaration isn't a prototype
Those functions are declared like this, without any parameters, as if
they were K&R functions:
void xuio_stat_wbuf_copied();
void xuio_stat_wbuf_nocopy();
and also their definitions lack any parameters:
void
xuio_stat_wbuf_copied()
{
XUIOSTAT_BUMP(xuiostat_wbuf_copied);
}
void
xuio_stat_wbuf_nocopy()
{
XUIOSTAT_BUMP(xuiostat_wbuf_nocopy);
}
Obviously, these should just have (void) as their parameter list. For
such a trivial change, it should be no problem to modify it locally, and
then notify upstream.
-Dimitry
signature.asc
Description: Message signed with OpenPGP using GPGMail
