Author: jmg
Date: Fri Jun 19 22:42:26 2015
New Revision: 284616
URL: https://svnweb.freebsd.org/changeset/base/284616

Log:
  change the KASSERT so it is meaningful, var is unsigned, so even
  when it wraps, it's still >= 0...
  
  Reported by:  Coverity
  CID:          1017564

Modified:
  head/sys/opencrypto/crypto.c

Modified: head/sys/opencrypto/crypto.c
==============================================================================
--- head/sys/opencrypto/crypto.c        Fri Jun 19 22:40:58 2015        
(r284615)
+++ head/sys/opencrypto/crypto.c        Fri Jun 19 22:42:26 2015        
(r284616)
@@ -1181,8 +1181,8 @@ crypto_kdone(struct cryptkop *krp)
        /* XXX: What if driver is loaded in the meantime? */
        if (krp->krp_hid < crypto_drivers_num) {
                cap = &crypto_drivers[krp->krp_hid];
+               KASSERT(cap->cc_koperations > 0, ("cc_koperations == 0"));
                cap->cc_koperations--;
-               KASSERT(cap->cc_koperations >= 0, ("cc_koperations < 0"));
                if (cap->cc_flags & CRYPTOCAP_F_CLEANUP)
                        crypto_remove(cap);
        }
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to