Andrew, On Fri, May 15, 2015 at 06:49:44AM +0000, Andrew Rybchenko wrote: A> Author: arybchik A> Date: Fri May 15 06:49:43 2015 A> New Revision: 282941 A> URL: https://svnweb.freebsd.org/changeset/base/282941 A> A> Log: A> sfxge: do not change CSUM_TSO when IFCAP_TSOx is changed A> A> It is simply not required since the kernel checks corresponding A> IFCAP_TSOx capability and CSUM_TSO in hw-assisted offloads. A> Note that CSUM_TSO is two bits (CSUM_IP_TSO|CSUM_IP6_TSO) and both bits A> are set in IPv4 and IPv6 mbufs.
I am not sure that this is a part of driver KPI. AFAIU, the if_capenable is user visible declaration of capabilities, and if_hwassist is stack visible. So, they should be changed together. At least all drivers do that. What made you to make such change to sfxge? Whether this is a good KPI or not is of course discussable. If you have ideas and improvements, let's do them in projects/ifnet branch. -- Totus tuus, Glebius. _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
