On Apr 29, 2015, at 4:29, Gleb Smirnoff <gleb...@freebsd.org> wrote: > On Wed, Apr 29, 2015 at 08:56:56AM +0000, Garrett Cooper wrote: > G> Author: ngie > G> Date: Wed Apr 29 08:56:56 2015 > G> New Revision: 282211 > G> URL: https://svnweb.freebsd.org/changeset/base/282211 > G> > G> Log: > G> ATF_REQUIRE_KERNEL_MODULE: use atf_skip, not ATF_REQUIRE_MSG so the > testcase > G> no longer bombs out > G> PLAIN_REQUIRE_KERNEL_MODULE: use printf + _exit, no err so the testcase > no > G> longer bombs out if it prints to stderr > G> > G> MFC after: 5 days > > This breaks buildworld since atf_skip() is a shell function, not a C one: > > glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-c > glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-sh/ > atf-sh/atf-sh.3:.Nm atf_skip ,
Yeah. I should really stop committing things after midnight and should have gotten CRs/produced tests which would have proved that my code was broken twice :(. Fixed in r282244..
signature.asc
Description: Message signed with OpenPGP using GPGMail
