On Wed, Apr 01, 2015 at 03:13:44PM +0300, Gleb Smirnoff wrote: > Mateusz, > > On Wed, Apr 01, 2015 at 02:02:29PM +0200, Mateusz Guzik wrote: > M> > You can add the seven_region variable to dev/null/null.c and implement > M> > the new device here. Now notrandom.c shares > 50% of code with null.c. > M> > M> Yeah I know, in fact I got most of the code from that driver. > M> > M> I just wanted to have a file with my own copyright in the tree, what's > M> so bad about it. > M> > M> If you feel strongly about it feel free to move it, but I would prefer > M> if you did not. > > You are increasing size of kernel object file merely for a selfish reason. >
Sure, but who does not? > While some systems do not care about kernel object size, some embedded do. > Size of source code also matters. You added new code in FreeBSD, that > is likely to be supported for a long time. Of course maintaing two files, > where one is paste of other, requires more efforts than maintaining > single file. > Fair point, but cmon. We can cut IPv6 instead. Net win. > Mateusz, if you keep the momentum, in the next years we will see lots > of files with your copyright. :) There is no reason to create one > just for this. Also, you can legitimately add your name into header of > null.c if you move code of notrandom there. > Yeah, but that's not the same as having my own file, even if I copy-pasted most of it. :( I understand you have concerns, but can we please leave this over the weekend? I'll be happy and maybe it will grow on you in the meantime. I must say this funcionality is so awesome it deserves a separate file regardless of who gets the copyright. -- Mateusz Guzik <mjguzik gmail.com> _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
