On Feb 28, 2015, at 6:57, Garrett Cooper <n...@freebsd.org> wrote: > Author: ngie > Date: Sat Feb 28 14:57:57 2015 > New Revision: 279393 > URL: https://svnweb.freebsd.org/changeset/base/279393 > > Log: > Pad RX copy alignment calculation to avoid illegal memory accesses > > The optimization made in r239940 is valid for struct mbuf's current structure > and size in FreeBSD, but hardcodes assumptions about sizes of struct mbuf, > which are unfortunately broken if additional data is added to the beginning > of > struct mbuf > > X-MFC note (discussed with rwatson): > > This change requires the MPKTHSIZE definition, which is only available after > head@r277203 and will not be MFCed as it breaks mbuf(9) KPI. > > A direct commit to stable/10 and merges to other branches to add the > necessary > definitions to work with the code as-is will be done to facilitate this MFC > > PR: 194314 > MFC after: 2 weeks > Approved/Reviewed by: erj, jfv > Sponsored by: EMC / Isilon Storage Division
I forgot to note that the fix was submitted by erj in the PR. I’ll fix that in the MFC message. Thank you very much for the help Eric and Jack!
signature.asc
Description: Message signed with OpenPGP using GPGMail
