On 02/25/15 at 09:59P, Adrian Chadd wrote: > Author: adrian > Date: Wed Feb 25 21:59:03 2015 > New Revision: 279300 > URL: https://svnweb.freebsd.org/changeset/base/279300 > > Log: > Remove taskqueue_start_threads_pinned(); there's noa generic cpuset version > of this. > > Sponsored by: Norse Corp, Inc. > > Modified: > head/sys/kern/subr_taskqueue.c > head/sys/sys/taskqueue.h > > Modified: head/sys/kern/subr_taskqueue.c > ============================================================================== > --- head/sys/kern/subr_taskqueue.c Wed Feb 25 21:44:53 2015 > (r279299) > +++ head/sys/kern/subr_taskqueue.c Wed Feb 25 21:59:03 2015 > (r279300) > @@ -659,30 +659,6 @@ taskqueue_start_threads_cpuset(struct ta > return (error); > } > > -int > -taskqueue_start_threads_pinned(struct taskqueue **tqp, int count, int pri, > - int cpu_id, const char *name, ...) > -{ > - cpuset_t mask; > - va_list ap; > - int error; > - > - /* > - * In case someone passes in NOCPU, just fall back to the > - * default behaviour of "don't pin". > - */ > - if (cpu_id != NOCPU) { > - CPU_ZERO(&mask); > - CPU_SET(cpu_id, &mask); > - } > - > - va_start(ap, name); > - error = _taskqueue_start_threads(tqp, count, pri, > - cpu_id == NOCPU ? NULL : &mask, name, ap); > - va_end(ap); > - return (error); > -} > - > static inline void > taskqueue_run_callback(struct taskqueue *tq, > enum taskqueue_callback_type cb_type) > > Modified: head/sys/sys/taskqueue.h > ============================================================================== > --- head/sys/sys/taskqueue.h Wed Feb 25 21:44:53 2015 (r279299) > +++ head/sys/sys/taskqueue.h Wed Feb 25 21:59:03 2015 (r279300) > @@ -74,10 +74,6 @@ int taskqueue_start_threads(struct taskq > const char *name, ...) __printflike(4, 5); > int taskqueue_start_threads_cpuset(struct taskqueue **tqp, int count, > int pri, cpuset_t *mask, const char *name, ...) __printflike(5, 6); > -int taskqueue_start_threads_pinned(struct taskqueue **tqp, int count, > - int pri, int cpu_id, const char *name, > - ...) __printflike(5, 6); > - > int taskqueue_enqueue(struct taskqueue *queue, struct task *task); > int taskqueue_enqueue_timeout(struct taskqueue *queue, > struct timeout_task *timeout_task, int ticks); >
Can you please update the manpage if you haven't already? Cheers, Hiren
pgpSehI8OcQ2T.pgp
Description: PGP signature
