Author: arybchik
Date: Sun Feb 22 07:18:38 2015
New Revision: 279146
URL: https://svnweb.freebsd.org/changeset/base/279146

Log:
  sfxge: use sparse index to retrieve sensor value
  
  Submitted by:   Andrew Jackson <ajackson at solarflare.com>
  Sponsored by:   Solarflare Communications, Inc.
  Approved by:    gnn (mentor)

Modified:
  head/sys/dev/sfxge/common/siena_mon.c

Modified: head/sys/dev/sfxge/common/siena_mon.c
==============================================================================
--- head/sys/dev/sfxge/common/siena_mon.c       Sun Feb 22 07:17:35 2015        
(r279145)
+++ head/sys/dev/sfxge/common/siena_mon.c       Sun Feb 22 07:18:38 2015        
(r279146)
@@ -105,6 +105,7 @@ siena_mon_decode_stats(
        uint16_t mc_sensor;
        size_t mc_sensor_max;
        uint32_t vmask = 0;
+       uint32_t idx = 0;
 
        /* Assert the MC_CMD_SENSOR and EFX_MON_STATE namespaces agree */
        SIENA_STATIC_SENSOR_ASSERT(OK);
@@ -125,18 +126,19 @@ siena_mon_decode_stats(
        for (mc_sensor = 0; mc_sensor < mc_sensor_max; ++mc_sensor) {
                uint16_t efx_sensor = sensor_map[mc_sensor];
 
-               if (efx_sensor == SIENA_MON_WRONG_PORT)
+               if (~dmask & (1 << mc_sensor))
                        continue;
-               EFSYS_ASSERT(efx_sensor < EFX_MON_NSTATS);
+               idx++;
 
-               if (~dmask & (1 << mc_sensor))
+               if (efx_sensor == SIENA_MON_WRONG_PORT)
                        continue;
+               EFSYS_ASSERT(efx_sensor < EFX_MON_NSTATS);
 
                vmask |= (1 << efx_sensor);
                if (value != NULL && esmp != NULL && !EFSYS_MEM_IS_NULL(esmp)) {
                        efx_mon_stat_value_t *emsvp = value + efx_sensor;
                        efx_dword_t dword;
-                       EFSYS_MEM_READD(esmp, 4 * mc_sensor, &dword);
+                       EFSYS_MEM_READD(esmp, 4 * (idx - 1), &dword);
                        emsvp->emsv_value =
                            (uint16_t)EFX_DWORD_FIELD(
                                dword,
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to