On 2015-02-06 22:23, Garrett Cooper wrote:
On Feb 6, 2015, at 18:38, James Gritton <ja...@freebsd.org> wrote:
On 2015-02-06 19:23, Garrett Cooper wrote:
On Feb 6, 2015, at 9:54, Jamie Gritton <ja...@freebsd.org> wrote:
Author: jamie
Date: Fri Feb 6 17:54:53 2015
New Revision: 278323
URL: https://svnweb.freebsd.org/changeset/base/278323
Log:
Add mount.procfs jail parameter, so procfs can be mounted when a
prison's
root is in its fstab.
Also fix a typo while I'm at it.
PR: 197237 197066
MFC after: 3 days
Modified:
head/etc/rc.d/jail
head/usr.sbin/jail/command.c
head/usr.sbin/jail/config.c
head/usr.sbin/jail/jail.8
head/usr.sbin/jail/jail.c
head/usr.sbin/jail/jailp.h
I think you broke the Jenkins tests runs, and potentially jail
support
in some edgecases:
https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/651/
Where do I go from here? There error you refer to certainly seems
jail-related, which leads me to guess at something disconnected
between the matching rc.d/jail and jail(8) change (i.e. using the new
rc file with the old jail program). But that's really just a wild
guess. Is there somewhere I look for more information? For example,
where does Jenkins actually do its thing?
Sorry for being so stupid in this - Jenkins has only been on the very
edge of my awareness until now.
I honestly don’t think it’s Jenkins because Jenkins runs in bhyve. I
think you accidentally broke option handling in the jail configuration
(please see my other reply about added “break;” statements).
Oh I figure I broke something, not blaming Jenkins or anything like that
- merely voicing my ignorance of how it's all put together :-). My
guess is that the jail(8) changes were good (I tested those), and for
now I've reverted the rc script change so the old (untouched) jail
options will be used.
pgrep uses /proc to determine whether or not a process is running. If
it’s not properly mounted or the jail isn’t started properly, that
could cause the issues seen here. I know because I’ve tried running
these tests before in an attempt to fix them, and this was one of the
things I ran into.
You can verify your changes by doing:
% (cd /usr/tests/bin/pkill; sudo kyua test)
Cheers!
OK, now I'm getting somewhere! I'll try that test.
- Jamie
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
