On 15 January 2015 at 13:53, John Baldwin <j...@freebsd.org> wrote: > > I think it's been a > clear practice with all other changes reviewed in phabric to date that > the committer only lists people in 'Reviewed by' who actually signed off > on the patch, not just the list of people asked to review it.
This point is worth repeating. Phabricator is an add-on tool to aid in pre-commit review, but is not a required part of our process and doesn't change the meaning of commit message metadata fields. "Reviewed by" in a commit message means exactly what it always has: that those listed have reasonably carefully reviewed the change and are willing to put their name on it. _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
