Other architectures (PowerPC, for example) seem to have this same code there by copy and paste. Any chance you could do a global sweep?
-Nathan

On 01/01/15 17:00, Konstantin Belousov wrote:
Author: kib
Date: Fri Jan  2 01:00:38 2015
New Revision: 276522
URL: https://svnweb.freebsd.org/changeset/base/276522

Log:
   Actually remove GIANT_REQUIRED, declared but not done in r263475.
   Style.
Sponsored by: The FreeBSD Foundation
   MFC after:   1 week

Modified:
   head/sys/amd64/amd64/mem.c

Modified: head/sys/amd64/amd64/mem.c
==============================================================================
--- head/sys/amd64/amd64/mem.c  Fri Jan  2 00:57:40 2015        (r276521)
+++ head/sys/amd64/amd64/mem.c  Fri Jan  2 01:00:38 2015        (r276522)
@@ -81,8 +81,6 @@ memrw(struct cdev *dev, struct uio *uio,
        int error, o, sflags;
        vm_offset_t addr, eaddr;
- GIANT_REQUIRED;
-
        error = 0;
        c = 0;
        sflags = curthread_pflags_set(TDP_DEVMEMIO);
@@ -110,8 +108,7 @@ kmemphys:
                        }
                        error = uiomove((void *)v, (int)c, uio);
                        continue;
-               }
-               else if (dev2unit(dev) == CDEV_MINOR_KMEM) {
+               } else if (dev2unit(dev) == CDEV_MINOR_KMEM) {
                        v = uio->uio_offset;
if (v >= DMAP_MIN_ADDRESS && v < DMAP_MAX_ADDRESS) {


_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to