John Baldwin wrote this message on Fri, Dec 12, 2014 at 15:23 -0500:
> On Friday, December 12, 2014 07:56:38 PM John-Mark Gurney wrote:
> > Author: jmg
> > Date: Fri Dec 12 19:56:36 2014
> > New Revision: 275732
> > URL: https://svnweb.freebsd.org/changeset/base/275732
> >
> > Log:
> > Add some new modes to OpenCrypto. These modes are AES-ICM (can be used
> > for counter mode), and AES-GCM. Both of these modes have been added to
> > the aesni module.
> >
> > Obtained from: p4: //depot/projects/opencrypto
> > Relnotes: yes
> > Sponsored by: FreeBSD Foundation
> > Sponsored by: NetGate
>
> No reviewers? (I thought FF projects required a reviewer?) Were you not
> able
> to get other folks to review this when you asked?
>
> With crypto involved, it would seem like a good idea to have run this by
> secteam if you hadn't. (If you did, something like 'Silence from: secteam'
> in the commit log would have let us know you tried and didn't get any
> feedback).
Sorry, I did get reviewers for specific parts of the project... But
they were third party reviewers...
Watson Ladd did the software AES review, and Mike Hamburg did the
AES-NI review.
Also, I posted an earlier version of this patch to -security and
-current over a month ago, and didn't get any significant responses...
Sorry for not including that in the commit. Want me to do a null
commit to record it? or?
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
