Author: kib
Date: Fri Dec 12 09:37:18 2014
New Revision: 275727
URL: https://svnweb.freebsd.org/changeset/base/275727

Log:
  For architectures where time_t is wide enough, in particular, 64bit
  platforms, avoid overflow after year 2038 in clock_ct_to_ts().
  
  PR:   195868
  Reviewed by:  bde
  Sponsored by: The FreeBSD Foundation
  MFC after:    1 week

Modified:
  head/sys/kern/subr_clock.c

Modified: head/sys/kern/subr_clock.c
==============================================================================
--- head/sys/kern/subr_clock.c  Fri Dec 12 09:22:52 2014        (r275726)
+++ head/sys/kern/subr_clock.c  Fri Dec 12 09:37:18 2014        (r275727)
@@ -133,7 +133,6 @@ print_ct(struct clocktime *ct)
 int
 clock_ct_to_ts(struct clocktime *ct, struct timespec *ts)
 {
-       time_t secs;
        int i, year, days;
 
        year = ct->year;
@@ -167,11 +166,10 @@ clock_ct_to_ts(struct clocktime *ct, str
                days += days_in_month(year, i);
        days += (ct->day - 1);
 
-       /* Add hours, minutes, seconds. */
-       secs = ((days * 24 + ct->hour) * 60 + ct->min) * 60 + ct->sec;
-
-       ts->tv_sec = secs;
+       ts->tv_sec = (((time_t)days * 24 + ct->hour) * 60 + ct->min) * 60 +
+           ct->sec;
        ts->tv_nsec = ct->nsec;
+
        if (ct_debug)
                printf(" = %ld.%09ld\n", (long)ts->tv_sec, (long)ts->tv_nsec);
        return (0);
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to