On Nov 20, 2014, at 8:28 AM, Andrey V. Elsukov <a...@freebsd.org> wrote:
> On 19.11.2014 21:49, Warner Losh wrote: >> >> On Nov 19, 2014, at 11:00 AM, Andrey V. Elsukov <a...@freebsd.org> wrote: >> >>> On 19.11.2014 19:20, Warner Losh wrote: >>>>> Probably you need to use basetable->gpt_entries here instead of >>>>> MAXPARTITIONS. >>>> >>>> I’m having trouble connecting the dots between GPT and BSDlabels. Why >>>> would this field be relevant? Is it just poorly named? MAXPARTITIONS >>> >>> gpt_entries isn't related to GPT, it is `geom partition table's` number >>> of partitions entries. Each instance of partition table (i.e. geom) can >>> have own number of partitions. MBR always has 4, but GPT or BSD can have >>> different numbers. >> >> Ah, OK. Thanks for the explanation. I understand. I’ll work up a patch. > > Hi, Warner > > since there are some reports about strange behavior of old utilities > after this commit, maybe we won't repair them by this way? > What you think about this path? It doesn’t thrill me. What’s it trying to do? And localizing it to fsck is useless. And where are these reports? Warner
signature.asc
Description: Message signed with OpenPGP using GPGMail
