On 08 Nov 2014, at 16:03 , Gleb Smirnoff <gleb...@freebsd.org> wrote:
> On Sat, Nov 08, 2014 at 03:06:20PM +0000, Bjoern A. Zeeb wrote: > B> > Modified: head/sys/net/if.c > B> > > ============================================================================== > B> > --- head/sys/net/if.c Sat Nov 8 06:43:33 2014 (r274273) > B> > +++ head/sys/net/if.c Sat Nov 8 07:23:01 2014 (r274274) > B> > @@ -265,13 +265,12 @@ ifnet_byindex_ref(u_short idx) > B> > * Allocate an ifindex array entry; return 0 on success or an error on > B> > * failure. > B> > */ > B> > -static int > B> > -ifindex_alloc_locked(u_short *idxp) > B> > +static u_short > B> > B> That feels like going backwards; we should really make sure we can > support ifindexes >> 64k > > This isn't backwards, since if_index was u_short before the commit. > > I will take into account your wish and see if we can enlarge if_index. Yeah, I think we fixed most of the APIs to be able to extend it and brooks had a spare a while ago I think. Last time this was discussed the leaning was to go straight to uint64_t to avoid any problems for the next two decades ;-) /bz — Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983 _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
