On Sat, Nov 1, 2014 at 7:56 AM, Bjoern A. Zeeb wrote: > > On 31 Oct 2014, at 19:15 , Luiz Otavio O Souza wrote: > >> Author: loos >> Date: Fri Oct 31 19:15:14 2014 >> New Revision: 273917 >> URL: https://svnweb.freebsd.org/changeset/base/273917 >> >> Log: >> Fix the gpiobus locking by using a more sane model where it isn't necessary >> hold the gpiobus lock between the gpio calls. >> >> gpiobus_acquire_lock() now accepts a third parameter which tells gpiobus >> what to do when the bus is already busy. >> >> When GPIOBUS_WAIT wait is used, the calling thread will be put to sleep >> until the bus became free. >> >> With GPIOBUS_DONTWAIT the calling thread will receive EWOULDBLOCK right >> away and then it can act upon. >> >> This fixes the gpioiic(4) locking issues that arises when doing multiple >> concurrent access on the bus. > > I guess it was this commit that broke things: > > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c: In function > 'gpioled_control': > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: 'GPIOBUS_DONTWAIT' > undeclared (first use in this function) > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: (Each undeclared > identifier is reported only once > /scratch/tmp/bz/head.svn/sys/dev/gpio/gpioled.c:88: error: for each function > it appears in.) > --- gpioled.o --- > *** [gpioled.o] Error code 1 > > bmake: stopped in > /storage/head/obj/mips.mips/scratch/tmp/bz/head.svn/sys/AP121 > --- buildkernel --- > *** [buildkernel] Error code 1
Fixed in r273926. Sorry for the breakage. Luiz _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
