Author: delphij
Date: Sat Sep 13 16:41:39 2014
New Revision: 271527
URL: http://svnweb.freebsd.org/changeset/base/271527

Log:
  MFV r271511:
  
  Use fnvlist_* to make code more readable.
  
  Illumos issue:
      5135 zpool_find_import_cached() can use fnvlist_*
  
  MFC after:    2 weeks

Modified:
  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
Directory Properties:
  head/cddl/contrib/opensolaris/   (props changed)
  head/cddl/contrib/opensolaris/lib/libzfs/   (props changed)

Modified: head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
==============================================================================
--- head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c     Sat Sep 
13 16:26:14 2014        (r271526)
+++ head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c     Sat Sep 
13 16:41:39 2014        (r271527)
@@ -20,7 +20,7 @@
  */
 /*
  * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
- * Copyright (c) 2012 by Delphix. All rights reserved.
+ * Copyright (c) 2013 by Delphix. All rights reserved.
  * Copyright 2014 Nexenta Systems, Inc. All rights reserved.
  */
 
@@ -1426,21 +1426,15 @@ zpool_find_import_cached(libzfs_handle_t
 
        elem = NULL;
        while ((elem = nvlist_next_nvpair(raw, elem)) != NULL) {
-               verify(nvpair_value_nvlist(elem, &src) == 0);
+               src = fnvpair_value_nvlist(elem);
 
-               verify(nvlist_lookup_string(src, ZPOOL_CONFIG_POOL_NAME,
-                   &name) == 0);
+               name = fnvlist_lookup_string(src, ZPOOL_CONFIG_POOL_NAME);
                if (poolname != NULL && strcmp(poolname, name) != 0)
                        continue;
 
-               verify(nvlist_lookup_uint64(src, ZPOOL_CONFIG_POOL_GUID,
-                   &this_guid) == 0);
-               if (guid != 0) {
-                       verify(nvlist_lookup_uint64(src, ZPOOL_CONFIG_POOL_GUID,
-                           &this_guid) == 0);
-                       if (guid != this_guid)
-                               continue;
-               }
+               this_guid = fnvlist_lookup_uint64(src, ZPOOL_CONFIG_POOL_GUID);
+               if (guid != 0 && guid != this_guid)
+                       continue;
 
                if (pool_active(hdl, name, this_guid, &active) != 0) {
                        nvlist_free(raw);
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to