On Wed, Sep 10, 2014 at 10:41:00AM -0400, John Baldwin wrote: > On Tuesday, September 09, 2014 11:58:13 AM Konstantin Belousov wrote: > > On Sat, Sep 06, 2014 at 04:04:49PM -0400, John Baldwin wrote: > > Move of the code to initialize CPU from identcpu() to initializecpu() > > seems to be a fix on its own. Since you are moving the fragments > > around, would you mind start using CPUID_MODEL/STEPPING etc constants ? > > The code was ancient, probably predating the defines. > > I will probably split this up into a couple of commits one of which will be > to move register setting from identcpu.c to initcpu.c. I can look at using > the constants, but in particular when using CPUID_TO_*() the logic is slightly > different (e.g. you have to check for model and family values for '6' instead > of '60' or '600'), so I would prefer to do those changes as a separate commit > to help with debugging in the future if I get one wrong. > I only asked about CPUID_MODEL etc constants (masks), which does not require the logic change. I think that CPUID_TO_*() is simply not suitable there.
pgpVzwnEgntQp.pgp
Description: PGP signature
