On Mon, 4 Aug 2014, Garrett Cooper wrote:
Log: Move a -L argument from LDADD to LDFLAGSPhabric: D525 (part of a larger patch) Reviewed by: jmmv Approved by: jmmv (co-mentor) Modified: head/libexec/rtld-elf/tests/target/Makefile Modified: head/libexec/rtld-elf/tests/target/Makefile ============================================================================== --- head/libexec/rtld-elf/tests/target/Makefile Mon Aug 4 05:46:10 2014 (r269504) +++ head/libexec/rtld-elf/tests/target/Makefile Mon Aug 4 05:49:13 2014 (r269505) @@ -6,7 +6,9 @@ PROG= target BINDIR= ${TESTSBASE}${TESTSDIR}/libexec/rtld-elf CFLAGS+= -I${.CURDIR}/../libpythagoras -LDADD= -L${.OBJDIR}/../libpythagoras -lpythagoras + +LDFLAGS+= -L${.OBJDIR}/../libpythagoras +LDADD= -lpythagoras MAN=
I hope this fixes the error found by "make checkdpadd". -L is too hard for the current "make checkdpadd" to handle. Old aout versions worked better using linker support. They also found the correct dependencies (on shared libraries for shared linkage, not the pseudo-dependenci on the hard-coded static librar for shared linkage). "make checkdpadd" currently finds broken 143 makefiles with inconsistent DPADD. 62 of them are for clang. Most of these misuse DPADD for headers. The next largest source of errors is libtermcapw. LIBTERMCAPW is missing in bsd.libnames.mk. This breaks about 29 makefiles where LIBTERMCAP was blindly replaced by LIBTERMCAPW. bsd.libnames.mk and DPADD were unnecessary with the old aout versions. Bruce _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
