On Sat, 2014-07-26 at 10:33 -0400, Benjamin Kaduk wrote: > On Sat, Jul 26, 2014 at 12:09 AM, Ian Lepore <i...@freebsd.org> wrote: > > > Author: ian > > Date: Sat Jul 26 04:09:43 2014 > > New Revision: 269112 > > URL: http://svnweb.freebsd.org/changeset/base/269112 > > > > Log: > > The 'flags' variable is conflicting with some inline code in a header > > file > > ("variable flags shadows a global..."), just rename this variable to > > wish away the problem. > > > > Not trying to pick on you, but we have lots of places where we get > "variable <foo> shadows a global..." -- we have a global variable 'buf' in > the kernel namespace, for one :) > Do we think it's a good use of our time to try and get this to zero > instances? > > -Ben
It was breakage I had to fix to get it to build so I could move ahead to the changes I was actually trying to make. (We use this stuff at $work; it has actually been disconnected from the build in freebsd for quite a while and has bitrotted. My goal is basically diff reduction between our repo at work and the base, and closing a 3 year old PR.) I guess boot2 must build with -Werror or something -- I didn't even think about changing the flags, I just did the same thing we did at work a couple years ago. -- Ian _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
