On Sun, Jun 08, 2014 at 11:30:42AM -0700, Alfred Perlstein wrote: > On 6/8/14 11:27 AM, Konstantin Belousov wrote: > > On Sun, Jun 08, 2014 at 05:38:49PM +0000, Bjoern A. Zeeb wrote: > >> On 08 Jun 2014, at 17:29 , Bryan Drewery <bdrew...@freebsd.org> wrote: > >> > >>> Author: bdrewery > >>> Date: Sun Jun 8 17:29:31 2014 > >>> New Revision: 267233 > >>> URL: http://svnweb.freebsd.org/changeset/base/267233 > >>> > >>> Log: > >>> In preparation for ASLR [1] support add WITH_PIE to support building > >>> with -fPIE. > >>> > >>> This is currently an opt-in build flag. Once ASLR support is ready and > >>> stable > >>> it should changed to opt-out and be enabled by default along with ASLR. > >>> > >>> Each application Makefile uses opt-out to ensure that ASLR will be > >>> enabled by > >>> default in new directories when the system is compiled with PIE/ASLR. > >>> [2] > >>> > >>> Mark known build failures as NO_PIE for now. > >> No, no, no, no more NOs! > >> > >> I?ll leave it to others who understand the current build system in days > >> when it?s not broken to fix this entire splattering across all these > >> Makefiles; we really need a better way for this. > > I have no words to express my dissatisfaction with this commit. > > If change to the build of _some_ usermode binaries require patching > > of loader', csu and rtld Makefiles, obviously it is done wrong. > > > > Why almost half of the binaries require opt-out ? > > > > PLEASE REVERT THIS. > Wait. Does this not serve as a useful stake in the ground for people to > come in and update things? Instead of asking to back out, shouldn't we > be doing an announcement "ok folks, it's now time to fix this!" and move > forward? Otherwise we may never get any pie.
Let me reformulate. Somebody commits broken change, despite it was pointed out by many before the commit. From the changes it is obvious that people which proposed it do not understand what they hack on. And then, somebody else must run and 'fix' previously non-broken code. Sure, you get the pie.
pgpC0hYaQKAjg.pgp
Description: PGP signature
