On Sun, Jan 05, 2014 at 09:37:21PM -0800, Adrian Chadd wrote: > On 5 January 2014 19:51, Konstantin Belousov <kostik...@gmail.com> wrote: > > On Mon, Jan 06, 2014 at 03:48:32AM +0000, Adrian Chadd wrote: > >> Author: adrian > >> Date: Mon Jan 6 03:48:32 2014 > >> New Revision: 260363 > >> URL: http://svnweb.freebsd.org/changeset/base/260363 > >> > >> Log: > >> Correctly remove entries from the relevant receive ath_buf list before > >> freeing them. > >> > >> The current code would walk the list and call the buffer free, which > >> didn't remove it from any lists before pushing it back on the free list. > >> > >> Tested: AR9485, STA mode > >> > >> Noticed by: dil...@apollo.dragonflybsd.org > > This is a NOP, right ? > > Nope. the previous version didn't remove the entries from the list. > that's the bug. Hm, you mean that the previous version did not TAILQ_INIT() after the loop ? Then I agree.
pgpDw9ToJlDtL.pgp
Description: PGP signature
