Author: glebius
Date: Sun Dec 29 18:34:29 2013
New Revision: 260046
URL: http://svnweb.freebsd.org/changeset/base/260046
Log:
Fix the parse type for NGM_LISTTYPES.
Actually, text versions of generic commands are not used, since ngctl(8)
uses binary messages for them. And to request a text command one needs
a working ngctl(8). That's why the bug was never discovered. I'm pondering
on removing the text support for generic commands.
Found by: dim with clang 3.4
Modified:
head/sys/netgraph/ng_base.c
Modified: head/sys/netgraph/ng_base.c
==============================================================================
--- head/sys/netgraph/ng_base.c Sun Dec 29 17:43:37 2013 (r260045)
+++ head/sys/netgraph/ng_base.c Sun Dec 29 18:34:29 2013 (r260046)
@@ -473,7 +473,7 @@ static const struct ng_parse_type ng_gen
&ng_generic_linkinfo_array_type_info
};
-DEFINE_PARSE_STRUCT_TYPE(typelist, TYPELIST, (&ng_generic_nodeinfoarray_type));
+DEFINE_PARSE_STRUCT_TYPE(typelist, TYPELIST, (&ng_generic_typeinfoarray_type));
DEFINE_PARSE_STRUCT_TYPE(hooklist, HOOKLIST,
(&ng_generic_nodeinfo_type, &ng_generic_linkinfo_array_type));
DEFINE_PARSE_STRUCT_TYPE(listnodes, LISTNODES,
@@ -549,7 +549,7 @@ static const struct ng_cmdlist ng_generi
NGM_LISTTYPES,
"listtypes",
NULL,
- &ng_generic_typeinfo_type
+ &ng_generic_typelist_type
},
{
NGM_GENERIC_COOKIE,
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
