On Fri, Sep 06, 2013 at 09:46:45AM +0000, David Chisnall wrote: > --- head/lib/libiconv_modules/Makefile Fri Sep 6 09:08:40 2013 > (r255296) > +++ head/lib/libiconv_modules/Makefile Fri Sep 6 09:46:44 2013 > (r255297) > @@ -2,6 +2,9 @@ > > .include <bsd.own.mk> > > +CFLAGS+= -Dbool=_Bool > +.export CFLAGS > + > SUBDIR= BIG5 DECHanyu EUC EUCTW GBK2K HZ ISO2022 JOHAB MSKanji UES > UTF1632 \ > UTF7 UTF8 VIQR ZW iconv_none iconv_std mapper_646 mapper_none \ > mapper_parallel mapper_serial mapper_std mapper_zone
This is extremely rude. Such things are traditionally (and properly) done with Makefile.inc in our tree. Look at the very beginning of mk/bsd.init.mk. But the whole commit is hack. If you want to use C99 _Bool, use it directly instead of obfuscating the code through the build system.
pgpsa13juBdOr.pgp
Description: PGP signature
