Author: kib
Date: Fri Aug 30 07:37:45 2013
New Revision: 255057
URL: http://svnweb.freebsd.org/changeset/base/255057

Log:
  Move the definition of the struct unrhdr into a separate header file,
  to allow embedding the struct.  Add init_unrhdr(9) initializer, which
  sets up preallocated unrhdr.
  
  Reviewed by:  alc
  Tested by:    pho, bf

Added:
  head/sys/sys/_unrhdr.h   (contents, props changed)
Modified:
  head/sys/kern/subr_unit.c
  head/sys/sys/systm.h

Modified: head/sys/kern/subr_unit.c
==============================================================================
--- head/sys/kern/subr_unit.c   Fri Aug 30 06:21:00 2013        (r255056)
+++ head/sys/kern/subr_unit.c   Fri Aug 30 07:37:45 2013        (r255057)
@@ -68,8 +68,8 @@
  */
 
 #include <sys/types.h>
-#include <sys/queue.h>
 #include <sys/bitstring.h>
+#include <sys/_unrhdr.h>
 
 #ifdef _KERNEL
 
@@ -187,22 +187,6 @@ CTASSERT(sizeof(struct unr) == sizeof(st
 /* Number of bits in the bitmap */
 #define NBITS  ((int)sizeof(((struct unrb *)NULL)->map) * 8)
 
-/* Header element for a unr number space. */
-
-struct unrhdr {
-       TAILQ_HEAD(unrhd,unr)   head;
-       u_int                   low;    /* Lowest item */
-       u_int                   high;   /* Highest item */
-       u_int                   busy;   /* Count of allocated items */
-       u_int                   alloc;  /* Count of memory allocations */
-       u_int                   first;  /* items in allocated from start */
-       u_int                   last;   /* items free at end */
-       struct mtx              *mtx;
-       TAILQ_HEAD(unrfr,unr)   ppfree; /* Items to be freed after mtx
-                                          lock dropped */
-};
-
-
 #if defined(DIAGNOSTIC) || !defined(_KERNEL)
 /*
  * Consistency check function.
@@ -315,20 +299,12 @@ clean_unrhdr(struct unrhdr *uh)
        mtx_unlock(uh->mtx);
 }
 
-/*
- * Allocate a new unrheader set.
- *
- * Highest and lowest valid values given as parameters.
- */
-
-struct unrhdr *
-new_unrhdr(int low, int high, struct mtx *mutex)
+void
+init_unrhdr(struct unrhdr *uh, int low, int high, struct mtx *mutex)
 {
-       struct unrhdr *uh;
 
        KASSERT(low >= 0 && low <= high,
            ("UNR: use error: new_unrhdr(%d, %d)", low, high));
-       uh = Malloc(sizeof *uh);
        if (mutex != NULL)
                uh->mtx = mutex;
        else
@@ -340,6 +316,21 @@ new_unrhdr(int low, int high, struct mtx
        uh->first = 0;
        uh->last = 1 + (high - low);
        check_unrhdr(uh, __LINE__);
+}
+
+/*
+ * Allocate a new unrheader set.
+ *
+ * Highest and lowest valid values given as parameters.
+ */
+
+struct unrhdr *
+new_unrhdr(int low, int high, struct mtx *mutex)
+{
+       struct unrhdr *uh;
+
+       uh = Malloc(sizeof *uh);
+       init_unrhdr(uh, low, high, mutex);
        return (uh);
 }
 

Added: head/sys/sys/_unrhdr.h
==============================================================================
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/sys/sys/_unrhdr.h      Fri Aug 30 07:37:45 2013        (r255057)
@@ -0,0 +1,51 @@
+/*-
+ * Copyright (c) 2004 Poul-Henning Kamp
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+
+#ifndef _SYS_UNRHDR_H
+#define _SYS_UNRHDR_H
+
+#include <sys/queue.h>
+
+struct mtx;
+
+/* Header element for a unr number space. */
+
+struct unrhdr {
+       TAILQ_HEAD(unrhd,unr)   head;
+       u_int                   low;    /* Lowest item */
+       u_int                   high;   /* Highest item */
+       u_int                   busy;   /* Count of allocated items */
+       u_int                   alloc;  /* Count of memory allocations */
+       u_int                   first;  /* items in allocated from start */
+       u_int                   last;   /* items free at end */
+       struct mtx              *mtx;
+       TAILQ_HEAD(unrfr,unr)   ppfree; /* Items to be freed after mtx
+                                          lock dropped */
+};
+
+#endif

Modified: head/sys/sys/systm.h
==============================================================================
--- head/sys/sys/systm.h        Fri Aug 30 06:21:00 2013        (r255056)
+++ head/sys/sys/systm.h        Fri Aug 30 07:37:45 2013        (r255057)
@@ -396,6 +396,7 @@ int root_mounted(void);
  */
 struct unrhdr;
 struct unrhdr *new_unrhdr(int low, int high, struct mtx *mutex);
+void init_unrhdr(struct unrhdr *uh, int low, int high, struct mtx *mutex);
 void delete_unrhdr(struct unrhdr *uh);
 void clean_unrhdr(struct unrhdr *uh);
 void clean_unrhdrl(struct unrhdr *uh);
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to