On Mon, 8 Jul 2013, Aleksandr Rybalko wrote:
On Mon, 1 Jul 2013 11:56:25 +1000 (EST)
Bruce Evans <b...@optusnet.com.au> wrote:
On Sun, 30 Jun 2013, Aleksandr Rybalko wrote:
Log:
Decrypt magic numbers - define names for fields of Generic Timer's CNTKCTL reg.
Submitted by: Ruslan Bukin <b...@bsdpad.com>
Modified:
head/sys/arm/arm/generic_timer.c
Modified: head/sys/arm/arm/generic_timer.c
==============================================================================
--- head/sys/arm/arm/generic_timer.c Sun Jun 30 19:36:17 2013
(r252424)
+++ head/sys/arm/arm/generic_timer.c Sun Jun 30 19:52:41 2013
(r252425)
@@ -66,7 +66,22 @@ __FBSDID("$FreeBSD$");
#define GENERIC_TIMER_REG_CTRL 0
#define GENERIC_TIMER_REG_TVAL 1
-#define CNTPSIRQ 29
+#define GENERIC_TIMER_CNTKCTL_PL0PTEN (1 << 9) /* Physical timer
registers
+ access from PL0 */
+#define GENERIC_TIMER_CNTKCTL_PL0VTEN (1 << 8) /* Virtual timer
registers
With names like these, the magic numbers are better. The prefix name
GENERIC_TIMER is especially bad. GT would be good.
Changed in r252780.
Thanks. It looks OK now.
Bruce
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"