On Jul 5, 2013, at 10:59, Dag-Erling Smørgrav <d...@des.no> wrote: > Tim Kientzle <kient...@freebsd.org> writes: >> Log: >> Fix -Wunsequenced warning. >> >> Submitted by: d...@gmx.com > > Neither approved by nor even discussed with the author and maintainer. > > (not saying it's wrong, but...)
Actually the warning (from clang trunk) was technically wrong, as a function call is a sequence point. I reported that upstream, and it got fixed in the mean time. That said, the construction still looked a little dodgy, and if the function call ever gets changed into a macro invocation, there could be trouble. :-) -Dimitry _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"