On May 30, 2013, at 7:09 AM, Brooks Davis wrote: > Author: brooks > Date: Thu May 30 14:09:58 2013 > New Revision: 251140 > URL: http://svnweb.freebsd.org/changeset/base/251140 > > Log: > Always define INSTALL_DDIR and define it such that it contains no extra > / characters rather than removing them later on. This should fix > release builds. > > PR: conf/178963 > Reviewed by: gjb, hrs
This is similar to a fix/enhancement I've made to Makefile.inc1 on my atf-tools-regression-convert branch: https://github.com/yaneurabeya/freebsd/blob/atf-tools-regression-convert/Makefile.inc1 . There are two key differences between my changes and this one: 1. I more consistently used INSTALL_DDIR in the Makefile as there were a number of spots where it wasn't doing that, but instead explicitly stating ${DESTDIR}/${DISTDIR}. 2. I properly deal with removing adjacent / by using the {2,} regexp quantifier as the current code only deals with even number of repeating /, not odd number of repeating / (not sure why this even mattered in the first place because this should be properly handled by whatever tool is calculating the absolute path, but I won't question why this is being done any further). Thanks! -Garrett _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"