Author: mav
Date: Mon Mar 25 06:31:17 2013
New Revision: 248695
URL: http://svnweb.freebsd.org/changeset/base/248695
Log:
Remove two bzero()s that are erasing only few more bytes then set later.
Modified:
head/sys/cam/ata/ata_all.c
Modified: head/sys/cam/ata/ata_all.c
==============================================================================
--- head/sys/cam/ata/ata_all.c Mon Mar 25 05:45:24 2013 (r248694)
+++ head/sys/cam/ata/ata_all.c Mon Mar 25 06:31:17 2013 (r248695)
@@ -367,7 +367,7 @@ void
ata_48bit_cmd(struct ccb_ataio *ataio, uint8_t cmd, uint16_t features,
uint64_t lba, uint16_t sector_count)
{
- bzero(&ataio->cmd, sizeof(ataio->cmd));
+
ataio->cmd.flags = CAM_ATAIO_48BIT;
if (cmd == ATA_READ_DMA48 ||
cmd == ATA_READ_DMA_QUEUED48 ||
@@ -391,13 +391,14 @@ ata_48bit_cmd(struct ccb_ataio *ataio, u
ataio->cmd.features_exp = features >> 8;
ataio->cmd.sector_count = sector_count;
ataio->cmd.sector_count_exp = sector_count >> 8;
+ ataio->cmd.control = 0;
}
void
ata_ncq_cmd(struct ccb_ataio *ataio, uint8_t cmd,
uint64_t lba, uint16_t sector_count)
{
- bzero(&ataio->cmd, sizeof(ataio->cmd));
+
ataio->cmd.flags = CAM_ATAIO_48BIT | CAM_ATAIO_FPDMA;
ataio->cmd.command = cmd;
ataio->cmd.features = sector_count;
@@ -409,6 +410,9 @@ ata_ncq_cmd(struct ccb_ataio *ataio, uin
ataio->cmd.lba_mid_exp = lba >> 32;
ataio->cmd.lba_high_exp = lba >> 40;
ataio->cmd.features_exp = sector_count >> 8;
+ ataio->cmd.sector_count = 0;
+ ataio->cmd.sector_count_exp = 0;
+ ataio->cmd.control = 0;
}
void
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
