On Mon, Mar 11, 2013 at 09:39:59AM +0100, Jean-S??bastien P??dron wrote:
> Hi Eitan!
>
> On 08.03.2013 19:14, Eitan Adler wrote:
> > On 8 March 2013 13:11, Jean-Sebastien Pedron <dumbb...@freebsd.org> wrote:
> >> @@ -125,8 +125,6 @@ static ssize_t ttm_mem_zone_store(struct
> >>
> >> static void ttm_mem_global_kobj_release(struct ttm_mem_global *glob)
> >> {
> >> -
> >> - free(glob, M_TTM_ZONE);
> >> }
> >
> > Can this function now be removed, because it appears to be empty?
>
> I guess we could get rid of the reference counting too, because we
> already have a refcount in the struct drm_global_reference containing
> struct ttm_mem_global or struct ttm_bo_global. This needs further
> investigation though.
>
> Konstantin, what do you think about this?I do not like neither removing the release method, nor reference counting. I made only absolutely neccessary changes to the TTM to get it into FreeBSD. What is proposed is a start of rewrite.
pgpnvV0ree5ip.pgp
Description: PGP signature
