On Saturday, January 05, 2013 04:22:52 AM Jaakko Heinonen wrote: > On 2013-01-04, John Baldwin wrote: > > > New Revision: 244585 > > > > > > Log: > > > Mangle label names containing spaces, non-printable characters '%' or > > > '"'. Mangling is only done for label names read from file system > > > metadata. Encoding resembles URL encoding. For example, the space > > > character becomes %20. > > > > Ouch, mangling spaces seems unfortunate. I guess fixing the devctl > > protocol is too hard, and/or we can't just encode it at the protocol > > layer but leave the actual device names untouched? > > I initially proposed changing the devctl protocol but in a private > discussion people preferred to not change the protocol. However, I think > that allowing the space character only might be possible without > changing the protocol as devd(8) can already handle strings enclosed in > double quotes. usb(4) already uses such devctl variables. > > > OS X preserves spaces in volume names and those can be quite common on > > ISO images, so mangling them really does seem to be a shame if we can > > avoid it. > > How important do you think this is? I understand that it's annoyance for > people upgrading their systems but labels with spaces can still be used.
I think if it isn't hard to do so, we should aim to preserve labels as they are generally intended to be human readable as-is. Just preserving spaces is probably sufficient for this as they are probably the most commonly used character in labels affected by this change. -- John Baldwin _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
