Hi Garrett, On Sun, Jan 6, 2013 at 7:22 PM, Garrett Cooper <yaneg...@gmail.com> wrote: > On Jan 5, 2013, at 11:18 AM, Neel Natu <n...@freebsd.org> wrote: > >> Author: neel >> Date: Sat Jan 5 19:18:50 2013 >> New Revision: 245066 >> URL: http://svnweb.freebsd.org/changeset/base/245066 >> >> Log: >> Teach the kernel to recognize that it is executing inside a bhyve virtual >> machine. >> >> Obtained from: NetApp >> >> Modified: >> head/sys/kern/subr_param.c >> >> Modified: head/sys/kern/subr_param.c >> ============================================================================== >> --- head/sys/kern/subr_param.c Sat Jan 5 18:48:23 2013 (r245065) >> +++ head/sys/kern/subr_param.c Sat Jan 5 19:18:50 2013 (r245066) >> @@ -160,6 +160,7 @@ static const char *const vm_bnames[] = { >> "Plex86", /* Plex86 */ >> "Bochs", /* Bochs */ >> "Xen", /* Xen */ >> + "BHYVE", /* bhyve */ >> NULL >> }; > > Interesting. This needs to be abstracted out a bit in order to work more > properly with VMware and other platforms that use the VT calls properly (and > get rid of some duplicated effort in tsc.c), but this is definitely a good > breadcrumb for cleaning up our vm detection and handling layer. >
Agreed. One possible approach would be to have an arch-dependent call which could check for presence of the CPUID2_HV. It would have the added bonus of getting rid of x86-specific code from subr_param.c. Also, I am not sure what you mean by "platforms that use the VT calls properly" ... best Neel > Thanks for the commit :). > > -Garrett _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
