On 2 Jan 2013, at 21:02, Andrew Turner wrote: >> This seemed to do the trick; what do you think of the attached? This >> isn't a board-specific change, so I dropped it into the common >> fdt_mips.c code. On the other hand, this left it a bit open as to >> what the right compatible= line to use was, so feedback there most >> welcome. > > The patch looks good. From my reading of [1] the compatible value > should be something like "mips,mips4k" as it's value is of the form > "<manufacturer>,<model>". > > I have been thinking the best way of merging these almost identical > decode functions. Linux appears to do it by providing a per-controller > function that can translate between the interrupt spec and the > configuration allowing them to have a generic parsing function that > doesn't need to check if the controller is compatible. I would like us > to have something similar as it will remove the duplicate function.
Sounds good on tweaking the compatible value -- I'll do that my local tree and merge to head fairly soon. I've now finished adapting our current suite of device drivers to use FDT, which took a couple of days but was fairly painless. On combining countless overlapping implementations: sounds reasonable to me. Having a single implementation of a default parsing function certainly wouldn't hurt -- or a single implementation of a generic one. Thanks, Robert _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
