On Tue, Nov 06, 2012 at 05:50:43PM -0500, Ben Kaduk wrote: > On Mon, Oct 22, 2012 at 1:50 PM, Konstantin Belousov <k...@freebsd.org> wrote: > > Author: kib > > Date: Mon Oct 22 17:50:54 2012 > > New Revision: 241896 > > URL: http://svn.freebsd.org/changeset/base/241896 > > > > Log: > > Remove the support for using non-mpsafe filesystem modules. > > > > In particular, do not lock Giant conditionally when calling into the > > filesystem module, remove the VFS_LOCK_GIANT() and related > > macros. Stop handling buffers belonging to non-mpsafe filesystems. > > > > The VFS_VERSION is bumped to indicate the interface change which does > > not result in the interface signatures changes. > > > > Conducted and reviewed by: attilio > > Tested by: pho > > > > Sorry for late reply. > > % --- head/sys/sys/namei.h 2011/12/29 12:28:05 228952 > % +++ head/sys/sys/namei.h 2012/10/22 17:50:54 241896 > % @@ -144,15 +144,11 @@ > % #define ISOPEN 0x00200000 /* caller is opening; return a real > vnode. */ > % #define NOCROSSMOUNT 0x00400000 /* do not cross mount points */ > % #define NOMACCHECK 0x00800000 /* do not perform MAC checks */ > % -#define MPSAFE 0x01000000 /* namei() must acquire Giant if > needed. */ > > It seems that removing the definition of MPSAFE causes out-of-tree > filesystem modules to not build. > Perhaps a definition can remain for some period to allow a smoother > transition? No, it shall not be left or restored, since its functionality is removed.
> Conditional on __FreeBSD_Version is the proper fix, of course, but > takes longer to get everywhere.
pgpDpNORkcvag.pgp
Description: PGP signature
