Re: svn commit: r242439 - in head/sys: dev/null geom kern sys

[Pawel Jakub Dawidek]

On Thu, Nov 01, 2012 at 05:01:05PM +0000, Alfred Perlstein wrote:
> +     strlcpy(dumpdevname, devname, sizeof(dumpdevname));
> +     if (strlen(dumpdevname) != strlen(devname)) {
> +             printf("set_dumper: device name truncated from '%s' -> '%s'\n",
> +                     devname, dumpdevname);
> +     }

More "standard" way to check this is the following:

        if (strlcpy(dumpdevname, devname, sizeof(dumpdevname)) >=
            sizeof(dumpdevname)) {
                printf("set_dumper: device name truncated from '%s' -> '%s'\n",
                        devname, dumpdevname);
        }

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

pgpv3d3PzQqWQ.pgp
Description: PGP signature