Fri, Jan 13, 2012 at 11:21:48AM +0400, Eygene Ryabinkin wrote:
> But seems like the whole problem is that I used the err() function
> instead of doing 'echo $errmsg; exit 1'. Such code shouldn't be
> conditionalized for the devd, since it is only syslog message that
> worried people; devd doesn't care what is written to the standard
> output or the standard error by the scripts it invokes once it become
> the daemon, since everything goes to /dev/null after calling
> daemon(3).
>
> So, seems like that the following dhclient_pre_check() will make
> everyone happy:
> {{{
> dhclient_pre_check()
> {
> if [ -z "${rc_force}" ] && ! dhcpif $ifn; then
> echo "'$ifn' is not a DHCP-enabled interface"
> exit 1
> fi
> }
> }}}
> Hadn't tested it yet, but will do it today.The attached patch that just changes 'err' to 'echo ...; exit 1' works fine for me. Any views on it? > The related topic: in the process of grepping for dhclient within > /etc, I had found that /etc/netstart still wants to invoke it. But it > will do a lone '/etc/rc.d/dhclient quietstart' and this will never > be useful in the current state of dhclient: it will refuse to process > any commands without the interface being specified. And since we > have the invocation of /etc/rc.d/netif just two lines above, I think > that it will be good to remove call to dhclient from /etc/netstart. > > At the time of the original addition of call to dhclient to /etc/netstart > (r114213), dhclient script had another form, > > http://svnweb.freebsd.org/base/head/etc/rc.d/dhclient?revision=113759&view=markup&pathrev=114213 > and it was really a normal rc.d script that requires only one argument. > Now it is more of a helper-type script. > . > Am I missing something important here or the removal can really be > done? Anyone can say anything about /etc/netstart issue? Thanks. -- Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
--- /usr/src/etc/rc.d/dhclient 2012-01-12 15:16:05.000000000 +0400
+++ /etc/rc.d/dhclient 2012-01-18 15:25:30.000000000 +0400
@@ -25,11 +25,11 @@
local msg
msg="'$ifn' is not a DHCP-enabled interface"
if [ -z "${rc_quiet}" ]; then
- err 1 "$msg"
+ echo "$msg"
else
debug "$msg"
- exit 1
fi
+ exit 1
fi
}
pgpT0Z9HQlvwv.pgp
Description: PGP signature
