2011/12/12 Andriy Gapon <a...@freebsd.org>: > on 12/12/2011 12:15 Kostik Belousov said the following: >> On Mon, Dec 12, 2011 at 10:05:13AM +0000, Andriy Gapon wrote: >>> Author: avg >>> Date: Mon Dec 12 10:05:13 2011 >>> New Revision: 228433 >>> URL: http://svn.freebsd.org/changeset/base/228433 >>> >>> Log: >>> put sys/systm.h at its proper place or add it if missing >>> >>> Reported by: lstewart, tinderbox >>> Pointyhat to: avg, attilio >>> MFC after: 1 week >>> MFC with: r228430 >>> >>> Modified: >>> head/sys/kern/kern_sx.c >>> head/sys/kern/vfs_cache.c >>> head/sys/security/mac/mac_framework.c >>> head/sys/security/mac/mac_priv.c >> It means that previously sx.h did not required systm.h and now it does ? >> Might be, you should move SCHEDULER_STOPPED and stop_scheduler declarations >> into sys/lock.h ? >> > > Strictly speaking it's sys/lockstat.h that now requires systm.h. > I am not an expert in FreeBSD header file organization, so I will just follow > whatever the experts advise.
I think that we should revert this part of the patch and just fix dtrace_probe() for pollution, this way we get the same effect and avoid namespace pollution (and still improve the MFC situation). I'll make a patch available in the next hour. Attilio -- Peace can only be achieved by understanding - A. Einstein _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
